I am making a simple react app with form that has radio buttons.
Here there is a default data available like,
const defaultData = [{ ContactMode: 3 }, { ContactMode: 2 }, { ContactMode: 2 }];
Requirement:
-> Need to iterate this defaultData
and assign their respective ContactMode
mode as checked in each row.
Working Snippet:
const { useState } = React;
const App = () => {
const [formValue, setFormValue] = useState({
ContactMode: 1
});
const defaultData = [{ ContactMode: 3 }, { ContactMode: 2 }, { ContactMode: 2 }];
const handleInputChange = (e, index) => {
const { name, value } = event.target;
setFormValue({
...formValue,
[name]: value
});
};
const submitData = () => {
console.log(formValue);
};
return (
<div>
<form>
{defaultData.map((item, index) => {
return (<React.Fragment>
<label> Contact Mode </label>
<input
type="radio"
name="ContactMode"
checked={item.ContactMode == 1}
value={1}
onChange={(event) => handleInputChange(index, event)}
/>{" "}
Email
<input
type="radio"
name="ContactMode"
checked={item.ContactMode == 2}
value={2}
onChange={(event) => handleInputChange(index, event)}
/>{" "}
Text
<input
type="radio"
name="ContactMode"
checked={item.ContactMode == 3}
value={3}
onChange={(event) => handleInputChange(index, event)}
/>{" "}
Both
<br />
<br />
<button type="button">
Save
</button>
<br />
<br />
<br />
</React.Fragment>);
})}
</form>
</div>
);
};
ReactDOM.render(<App />, document.getElementById("root"));
<script src=".11.0/umd/react.production.min.js"></script>
<script src=".11.0/umd/react-dom.production.min.js"></script>
<div id="root"></div>
I am making a simple react app with form that has radio buttons.
Here there is a default data available like,
const defaultData = [{ ContactMode: 3 }, { ContactMode: 2 }, { ContactMode: 2 }];
Requirement:
-> Need to iterate this defaultData
and assign their respective ContactMode
mode as checked in each row.
Working Snippet:
const { useState } = React;
const App = () => {
const [formValue, setFormValue] = useState({
ContactMode: 1
});
const defaultData = [{ ContactMode: 3 }, { ContactMode: 2 }, { ContactMode: 2 }];
const handleInputChange = (e, index) => {
const { name, value } = event.target;
setFormValue({
...formValue,
[name]: value
});
};
const submitData = () => {
console.log(formValue);
};
return (
<div>
<form>
{defaultData.map((item, index) => {
return (<React.Fragment>
<label> Contact Mode </label>
<input
type="radio"
name="ContactMode"
checked={item.ContactMode == 1}
value={1}
onChange={(event) => handleInputChange(index, event)}
/>{" "}
Email
<input
type="radio"
name="ContactMode"
checked={item.ContactMode == 2}
value={2}
onChange={(event) => handleInputChange(index, event)}
/>{" "}
Text
<input
type="radio"
name="ContactMode"
checked={item.ContactMode == 3}
value={3}
onChange={(event) => handleInputChange(index, event)}
/>{" "}
Both
<br />
<br />
<button type="button">
Save
</button>
<br />
<br />
<br />
</React.Fragment>);
})}
</form>
</div>
);
};
ReactDOM.render(<App />, document.getElementById("root"));
<script src="https://cdnjs.cloudflare./ajax/libs/react/16.11.0/umd/react.production.min.js"></script>
<script src="https://cdnjs.cloudflare./ajax/libs/react-dom/16.11.0/umd/react-dom.production.min.js"></script>
<div id="root"></div>
Expected output:
Contact Mode Email Text Both (Checked)
Contact Mode Email Text(Checked) Both
Contact Mode Email Text(Checked) Both
Note: I can't modify the name attribute name="ContactMode"
.. Reason is I also have individual save button each row and on click of that save button that particular row will gets saved.. And each row should have name="ContactMode"
..
Edit:
As my question is not clear in what I am trying to achieve, I am going to give the entire code here.
-> I have a stepper form in which Step 2 is employment section and by default I have the values to set into the form,
const dynamicData = [
{
EmploymentID: 1,
panyName: 'Company One',
designation: 'Designation One',
ContactMode: 3,
},
{
EmploymentID: 2,
panyName: 'Company two',
designation: 'Designation One',
ContactMode: 2,
},
];
-> Inside useEffect
hook I set the form value like,
React.useEffect(() => {
setExpanded(0);
setValue((prev) => {
const panyDetails = [...dynamicData];
return { ...prev, panyDetails };
});
}, []);
Here the form values with input boxes are binded properly but the radio button value doesn't gets checked.
-> There are two data's available but the first one will be expanded by default and whereas the second one will gets opened on click of the Expand
button below the first one.
-> On click of the save
button, that particular object (inputField
) will be console logged (testing only) along with modified data..
Here the ISSUE is if we modify the data then things are working fine but the radio checked attribute alone not making the item checked.. (Checked indication is not working)..
Please go to step 2 in the below given codesandbox to see the issue.. To see the second item, click on the expand button..
Please kindly help me to set default radio button value in each row.
Share Improve this question edited Nov 25, 2020 at 6:17 Undefined asked Nov 24, 2020 at 15:01 UndefinedUndefined 1,0216 gold badges28 silver badges52 bronze badges 8-
You defined
handleInputChange
to consume(e, index)
, but in the UI you invert the orderhandleInputChange(index, event)
. YourdefaultData
also has two{ ContactMode: 2 }
and no{ ContactMode: 1 }
, maybe this is intentional. As @vkvkvkv points out, using the samename
attribute across all radio inputs places them all in the same radio group and there can be only a single selected radio group value. – Drew Reese Commented Nov 24, 2020 at 17:02 - Do you have control over how the inputs are mapped? Can you share a bit more about how each button saves the particular row? How is the row identified? What is the data that is saved? I have an idea but it depends on your response to these questions in order to really understand your requirements/restrictions. – Drew Reese Commented Nov 24, 2020 at 19:38
- @DrewReese, I will edit the question soon but before that I have made a codesandbox with all the code I have here for you codesandbox.io/s/next-dynamic-testing-issue-forked-ebovz?file=/… .. In this form please go to step 2 (employment details) to see where I am placing the input boxes and radio button.. – Undefined Commented Nov 25, 2020 at 6:05
-
@DrewReese, This is an accordion form so there will be
Expand
andShrink
option which makes each data expandable on clickExpand
.. – Undefined Commented Nov 25, 2020 at 6:07 - @DrewReese, Please see the edit in question to have better understanding of your questions you mentioned in the above ment.. – Undefined Commented Nov 25, 2020 at 6:19
4 Answers
Reset to default 1In your sandbox I was able to get the radio buttons to work by
- Providing a unique
name
for each mapped radio group - Update the change handler to uniquely handle the
ContactMode
property.
Update the radio groups to use the current mapped index in order to make them unique among all mapped groups.
<div className="form-group col-sm-4">
<label className="inline-flex items-center mr-6">
<input
type="radio"
className="form-radio border-black"
name={`ContactMode-${index}`} // <-- append index to name
value={1}
checked={inputField.ContactMode === 1} // <-- use strict "==="
onChange={(event) => handleInputChange(index, event)}
/>
<span className="ml-2">Email</span>
</label>
</div>
<div className="form-group col-sm-4">
<label className="inline-flex items-center mr-6">
<input
type="radio"
className="form-radio border-black"
name={`ContactMode-${index}`}
value={2}
checked={inputField.ContactMode === 2}
onChange={(event) => handleInputChange(index, event)}
/>
<span className="ml-2">Text</span>
</label>
</div>
<div className="form-group col-sm-4">
<label className="inline-flex items-center mr-6">
<input
type="radio"
className="form-radio border-black"
name={`ContactMode-${index}`}
value={3}
checked={inputField.ContactMode === 3}
onChange={(event) => handleInputChange(index, event)}
/>
<span className="ml-2">Both</span>
</label>
</div>
In the handleInputChange
add a case to handle ContactMode
specially.
const handleInputChange = (index, event) => {
const { name, value } = event.target;
if (name === 'designation' && !isLettersOnly(value)) {
return;
}
if (name.startsWith('ContactMode')) { // <-- check name prefix
setValue((prev) => ({
...prev,
panyDetails: prev.panyDetails.map((detail, i) =>
i === index
? {
...detail,
ContactMode: Number(value), // <-- store back under correct key, as number for string equality check
}
: detail,
),
}));
return; // <-- return early so other state update is skipped!
}
setValue((prev) => {
const panyDetails = prev.panyDetails.map((v, i) => {
if (i !== index) {
return v;
}
return { ...v, [name]: value };
});
return { ...prev, panyDetails };
});
};
I think it due to that all of the radio have the same name attribute every group should have different name. for example:
name = " ex1"
name = "ex2"
name = "ex3"
for every new group due name like this.
if you do the same name it make everything messed up
another think you you ==
instead of ===
item.ContactMode == 3
it's better to use ===
@TalOrlanczyk's answer is right. You are printing 9 radio buttons in total and all have the same value in name attribute. So technically it is like having a radio group with 9 radio buttons which means that a radio group can only accept one value. I ran your code and it only selected "Text" on 3rd line.
If you are trying to have 3 separate rows (radio groups) you need to try something like this:
<input
type="radio"
name={"ContactMode"+index}
checked={item.ContactMode == 1}
value={1}
onChange={(event) => handleInputChange(index, event)}
/>{" "}
Email
<input
type="radio"
name={"ContactMode"+index}
checked={item.ContactMode == 2}
value={2}
onChange={(event) => handleInputChange(index, event)}
/>{" "}
Text
<input
type="radio"
name={"ContactMode"+index}
checked={item.ContactMode == 3}
value={3}
onChange={(event) => handleInputChange(index, event)}
/>{" "}
Try it and rerun your code
Here are some issues in your code...
Every time the ponent returns, the
.map
is called ondefaultData
. Hence not mapped to state.If you want the same name for each iteration, then you need to use
<form>
for every iteration else all the radio buttons will be grouped together, therefore only the last radio button shows as marked.It is better to use
===
instead of==
I have modified your code and defaultData
is used to initialize the state.
const { useState } = React;
const defaultData = [{ ContactMode: 3 }, { ContactMode: 2 }, { ContactMode: 2 }];
const App = () => {
const [formValue, setFormValue] = useState([...defaultData]);
const handleInputChange = (index, e) => {
const { name, value } = e.target;
const newFormValue = [...formValue];
newFormValue.splice(index,1,{[name]: value});
setFormValue(newFormValue);
};
const submitData = () => {
console.log(formValue);
};
return (
<div>
{formValue.map((item, index) => {
return (<form>
<label> Contact Mode </label>
<input
type="radio"
name="ContactMode"
checked={Number(item.ContactMode) === 1}
value={1}
onChange={(event) => handleInputChange(index, event)}
/>{" "}
Email
<input
type="radio"
name="ContactMode"
checked={Number(item.ContactMode) === 2}
value={2}
onChange={(event) => handleInputChange(index, event)}
/>{" "}
Text
<input
type="radio"
name="ContactMode"
checked={Number(item.ContactMode) === 3}
value={3}
onChange={(event) => handleInputChange(index, event)}
/>{" "}
Both
<br />
<br />
</form>);
})}
<button type="button" onClick={submitData}>
{" "}
Submit{" "}
</button>
</div>
);
};
ReactDOM.render(<App />, document.getElementById("root"));
<script src="https://cdnjs.cloudflare./ajax/libs/react/16.11.0/umd/react.production.min.js"></script>
<script src="https://cdnjs.cloudflare./ajax/libs/react-dom/16.11.0/umd/react-dom.production.min.js"></script>
<div id="root"></div>