Problem

I am trying to push a returning variables value into an array. This is my code, however I'm returning an empty array and am not sure what's wrong.

JavaScript

var my_arr = [];

function foo() {
  var unitValue = parseFloat($('#unitVal1').val());
  var percentFiner = parseFloat($('#percent1').val());
  var total = unitValue * 1000;

  return my_arr.push({
    unit: unitValue,
    percent: percentFiner
  });
}

Problem

I am trying to push a returning variables value into an array. This is my code, however I'm returning an empty array and am not sure what's wrong.

JavaScript

var my_arr = [];

function foo() {
  var unitValue = parseFloat($('#unitVal1').val());
  var percentFiner = parseFloat($('#percent1').val());
  var total = unitValue * 1000;

  return my_arr.push({
    unit: unitValue,
    percent: percentFiner
  });
}

• javascript
• arrays

• 1 it should be array of objects and can't see micronConv here. – Varit J Patel Commented Jul 20, 2016 at 17:44
• 2 Why so many upvotes? That code doesn't return an array. And did you check my_arr? – 1983 Commented Jul 20, 2016 at 17:59

2 Answers 2

return my_arr.push({
        unit:   unitValue, 
        percent: percentFiner});

This isn't returning the new Array - this is returning the new length of the Array! Split these out:

my_arr.push({
        unit:   unitValue, 
        percent: percentFiner});

return my_arr;

Array.push returns a length of the changed array, not the array itself

See the Docs