I'm trying this rough script idea. But it is not working.
<script>
function storeurl() {
var varurl = document.URL;
}
document.onclick = storeurl;
document.write(varurl);
</script>
varurl is set as the actual URL using document.URL function.
with <a href="#2">broogle</a>
then on click i would like varurl to be set to #2 and then echo.
In a perfect world this script would echo
http://url/#2
when clicking on the link
Any help? Thx
I'm trying this rough script idea. But it is not working.
<script>
function storeurl() {
var varurl = document.URL;
}
document.onclick = storeurl;
document.write(varurl);
</script>
varurl is set as the actual URL using document.URL function.
with <a href="#2">broogle</a>
then on click i would like varurl to be set to #2 and then echo.
In a perfect world this script would echo
http://url/#2
when clicking on the link
Any help? Thx
Share Improve this question edited Apr 11, 2024 at 6:28 informatik01 16.4k11 gold badges78 silver badges108 bronze badges asked Jun 17, 2013 at 13:32 dansayagdansayag 771 gold badge3 silver badges8 bronze badges 4- 2 Well, what does it do? Does it do nothing? Make an error? Crash your puter? Make flying monkeys fall from the sky? Give you free waffles? Please clarify. – tckmn Commented Jun 17, 2013 at 13:33
-
1
varurlis private, you can't access it from outside its local scope which is inside thestoreurlfunction. – Sebas Commented Jun 17, 2013 at 13:34 - Isn't also document.onclick = storeurl; an issue since it should be: document.onclick = storeurl(); ? – Ghostwriter Commented Jun 17, 2013 at 13:59
- 1 doorknob why being mean? – dansayag Commented Jun 17, 2013 at 14:07
6 Answers
Reset to default 3Your varurl variable is scoped at method (function) level. This means it is not visible to code which runs outside of the function.
Also, the document.write code will execute when the script first runs i.e. before the click (should the click ever happen).
If you don't need to use varurl other than to write it to the document you can move the document.write code into the function and retain the narrow scope of varurl:
<script>
function storeurl() {
var varurl = document.URL;
document.write(varurl);
}
document.onclick = storeurl;
</script>
Otherwise move the variable definition out of the function so that it (the variable) bees a global:
<script>
var varurl;
function storeurl() {
varurl = document.URL;
document.write(varurl);
}
document.onclick = storeurl;
</script>
The var makes it a local variable to the function's scope. Plus you are trying to read it before it is even set.
For simply storing a URL in a variable, be it an external URL or the URL of the current page, and then either display it or do something else with it, you can follow what is shown in the code below:
<html>
<body>
<button onclick="go()">GO TO GOOGLE</button><br/>
<button onclick="show()">CLICK TO SHOW CURRENT URL</button><br/>
<p id="showhere"></p>
<script>
function go(){
var u = "http://www.google." ;
window.location.href = u; //takes you to google.
}
function show(){
var x = window.location.href;
document.getElementById("showhere").innerHTML = x;
//shows URL of current page below the buttons
}
</script>
</body>
</html>
You have made varurl location to the function it is declared in with var so it isn't visible from outside that function.
var varurl;
function storeurl() {
varurl = document.URL;
}
You are also writing its value immediately instead of doing so in the click event, so it won't have been set by the time you write().
function storeurl() {
var varurl = document.URL;
document.write(varurl);
}
document.onclick = storeurl;
It should work,
<script>
function storeurl() {
varurl = document.URL; // it should be Global variable, so remove var
document.write(varurl);//when you're declaring this outside of the function
}
document.onclick = storeurl;
</script>
change your code to
var varurl;
function storeurl() {
varurl = window.location.href;
}