Javascript: Getting greeting messages according to time

I am trying to display greeting message according to time.

For that I have created date object and getting hrs and displaying each message but due to some error I am not getting greeting message according to time. can anyone help me ?

code:

<!DOCTYPE html>
<html>
<head>
    <title>trail6</title>
</head>
<body>

    <p id="demo"></p>

    <script>

    var today = new Date()
    var curHr = today.getHours()

    if (curHr >= 0 && curHr < 6) {
        document.getElementById("demo").innerHTML = 'What are you doing that early?';
    } else if (curHr >= 6 && curHr <= 12) {
        document.getElementById("demo").innerHTML = 'Good Morning';
    } else if (curHr >= 12 && curHr < 17) {
        document.getElementById("demo").innerHTML = 'Good Afternoon';
    } else {
        document.getElementById("demo").innerHTML = 'Good Evening';
    }

</script>

</body>
</html>

I am trying to display greeting message according to time.

For that I have created date object and getting hrs and displaying each message but due to some error I am not getting greeting message according to time. can anyone help me ?

code:

<!DOCTYPE html>
<html>
<head>
    <title>trail6</title>
</head>
<body>

    <p id="demo"></p>

    <script>

    var today = new Date()
    var curHr = today.getHours()

    if (curHr >= 0 && curHr < 6) {
        document.getElementById("demo").innerHTML = 'What are you doing that early?';
    } else if (curHr >= 6 && curHr <= 12) {
        document.getElementById("demo").innerHTML = 'Good Morning';
    } else if (curHr >= 12 && curHr < 17) {
        document.getElementById("demo").innerHTML = 'Good Afternoon';
    } else {
        document.getElementById("demo").innerHTML = 'Good Evening';
    }

</script>

</body>
</html>

Share Improve this question edited Oct 15, 2017 at 20:49 asked Oct 15, 2017 at 19:34 pooja gajera 3836 silver badges22 bronze badges

1 What is your error? And did you console.log(curHr) to see what it says? You also are executing both if statements at the same time. When the time is 12. (curHr >= 6 && curHr <= 12) and (curHr >= 12 && curHr < 17) – Hunter Commented Oct 15, 2017 at 19:36
For starters, you have two conditions in your if/else that will return true if the curHr variable is 12. – Robert Wade Commented Oct 15, 2017 at 19:36
@RobertWade it does not matter, the first condition will be true and the second won't be entered – dhilt Commented Oct 15, 2017 at 19:39
In my code it's not showing greeting according to time. – pooja gajera Commented Oct 15, 2017 at 19:49

Add a ment |

3 Answers 3

Sorted by: Reset to default 8

Divide your day into 4 sets of 6 hours each, starting at 0.
Convert the result of floor(hour / 24 * 4) and use it as the message array index

const greets = [
  "What are you doing that early?",
  "Good Morning",
  "Good Afternoon",
  "Good Evening"
];

const index = Math.floor(new Date().getHours() / 24 * greets.length);

document.getElementById("demo").innerHTML = greets[index];

<div id=demo></div>

<!DOCTYPE html>
<html>
<head>
    <title>trail6</title>
</head>
<body>

    <p id="demo"></p>

    <script>

    var today = new Date()
    var curHr = today.getHours()

    if (curHr >= 0 && curHr < 6) {
        document.getElementById("demo").innerHTML = 'What are you doing that early?';
    } else if (curHr >= 6 && curHr < 12) {
        document.getElementById("demo").innerHTML = 'Good Morning';
    } else if (curHr >= 12 && curHr < 17) {
        document.getElementById("demo").innerHTML = 'Good Afternoon';
    } else {
        document.getElementById("demo").innerHTML = 'Good Evening';
    }

</script>

</body>
</html>

I got rid of the = sign before your first 12, otherwise your code executes correctly. And displays Good Afternoon to me. I console logged it, it works fine and displays accordingly. It must be Noon where you are at. As this is the only way your code could break, before the fix. Glad to be able to answer your question.

Works fine for me...

<!DOCTYPE html>
<html>
<head>
    <title>trail6</title>
</head>
<body>

    <p id="demo"></p>

    <script>

    var today = new Date()
    var curHr = today.getHours()

    if (curHr >= 0 && curHr < 6) {
        document.getElementById("demo").innerHTML = 'What are you doing that early?';
    } else if (curHr >= 6 && curHr <= 12) {
        document.getElementById("demo").innerHTML = 'Good Morning';
    } else if (curHr >= 12 && curHr < 17) {
        document.getElementById("demo").innerHTML = 'Good Afternoon';
    } else {
        document.getElementById("demo").innerHTML = 'Good Evening';
    }

</script>

</body>
</html>

科技改变生活-雨落星辰 - 所有的伟大,都源于一个勇敢的开始

Javascript: Getting greeting messages according to time - Stack Overflow

3 Answers 3

与本文相关的文章

评论列表(0)