I want to add filters in my project dynamically to the DI container. I want to reduce the workload and error probability in case there are too many filters in the future.

I made an application like the one below, I am not sure if it is a good and correct approach.

 public static class FilterExtensions
 {
     public static IServiceCollection AddFilters(this IServiceCollection services)
     {
         var filterTypes = Assembly.GetExecutingAssembly().GetTypes()
             .Where(t => t.IsClass && !t.IsAbstract && typeof(IAsyncActionFilter).IsAssignableFrom(t));

         foreach (var type in filterTypes)
         {
             services.AddScoped(type);
         }

         return services;
     }
 }

I want to add filters in my project dynamically to the DI container. I want to reduce the workload and error probability in case there are too many filters in the future.

I made an application like the one below, I am not sure if it is a good and correct approach.

 public static class FilterExtensions
 {
     public static IServiceCollection AddFilters(this IServiceCollection services)
     {
         var filterTypes = Assembly.GetExecutingAssembly().GetTypes()
             .Where(t => t.IsClass && !t.IsAbstract && typeof(IAsyncActionFilter).IsAssignableFrom(t));

         foreach (var type in filterTypes)
         {
             services.AddScoped(type);
         }

         return services;
     }
 }

• asp-core
• di-containers

1 Answer 1

In my opinion, I don't think this is a good approach, this will automatically add all the filter to the service but will make your application hard to manage.

Normally , the project will not just develop by yourself. If you are using this dynamically add IAsyncActionFilter implementations to DI container. Other member will not hard to identity your project action filter.

I suggest you could consider adding a filter class to put all adding filter method inside it and its clearly to manage the filter related codes.