I have a very stupid performance issue.

I have a ponent that uses ngStyle, and I'd prefer to not rewrite it. But each time I click random input on the same page (even from another ponent), ngStyle recalculates (and do it pretty slow).

Let's say I want to have a table of multiply with dynamic background:

<section>
  <div class="row" 
       *ngFor="let row of rows">
    <div class="col" 
         [ngStyle]="{'background-color': getBG(row*col)}" 
         *ngFor="let col of cols ">
      {{row * col}}
    </div>
  </div>
</section>

Then on the same page I want to add several inputs for some reason:

<section>
  <input type="text" [ngModel]="model1"/>
  <input type="text"[ngModel]="model2"/>
  <input type="text"[ngModel]="model3"/>
  <input type="text"[ngModel]="model4"/>
  <input type="text"[ngModel]="model5"/>
</section>

Now each time I click on one of those inputs - getBG() will be called. And even if that function just returns a string without any calculations - it's still super slow

Example at StackBlitz - just open console and try to click swiftly among different input fields or enter a value. Even as a user I can see it's not responsive at all

UPD1: My real-world case is much more plex. And already use ChangeDetectionStrategy.OnPush. Binding ngStyle to a value instead of function also doesn't help much - it faster but still slow (and produces a lot of plexity). What I want, it's probably a way to tell ngStyle to not recalculate until I'll ask explicitly. Maybe ChangeDetectorRef.detach()could help

I have a very stupid performance issue.

I have a ponent that uses ngStyle, and I'd prefer to not rewrite it. But each time I click random input on the same page (even from another ponent), ngStyle recalculates (and do it pretty slow).

Let's say I want to have a table of multiply with dynamic background:

<section>
  <div class="row" 
       *ngFor="let row of rows">
    <div class="col" 
         [ngStyle]="{'background-color': getBG(row*col)}" 
         *ngFor="let col of cols ">
      {{row * col}}
    </div>
  </div>
</section>

Then on the same page I want to add several inputs for some reason:

<section>
  <input type="text" [ngModel]="model1"/>
  <input type="text"[ngModel]="model2"/>
  <input type="text"[ngModel]="model3"/>
  <input type="text"[ngModel]="model4"/>
  <input type="text"[ngModel]="model5"/>
</section>

Now each time I click on one of those inputs - getBG() will be called. And even if that function just returns a string without any calculations - it's still super slow

Example at StackBlitz - just open console and try to click swiftly among different input fields or enter a value. Even as a user I can see it's not responsive at all

UPD1: My real-world case is much more plex. And already use ChangeDetectionStrategy.OnPush. Binding ngStyle to a value instead of function also doesn't help much - it faster but still slow (and produces a lot of plexity). What I want, it's probably a way to tell ngStyle to not recalculate until I'll ask explicitly. Maybe ChangeDetectorRef.detach()could help

• javascript
• angular
• typescript

• maybe you'd better avoid the function and map the bg colors into a matrix array (or an object with keys [row +'-'+col]) – G-Host Commented Jul 16, 2019 at 15:08
• This might help you : Angular : escape from change detection – Jeremy Thille Commented Jul 16, 2019 at 15:19
• 1 Function calls in template are universal performance killers. Don’t do it, run the function in your ponent once and assign it as a property on your columns and assign it that way. – bryan60 Commented Jul 16, 2019 at 15:31

2 Answers 2

That makes perfect sense. This is how Angular performs change detection. And this is Angular performing extra checks since you called a function in one of the data-binding syntaxes, here:

[ngStyle]="{'background-color': getBG(row*col)}" 

Angular performs Change Detection in three cases:

1. DOM Events.
2. AJAX Calls.
3. Timeouts / Intervals.

This is the case of DOM Events (click).

Now when performing Change Detection, Angular check whether a particular variable in the Component has changed.

That's pretty straight forward in case of properties. But not so straight-forward in case of functions.

You see, the only way to determine whether the value of a function has changed is by calling it.

So Angular is doing just that.

SOLUTION:

Just create a matrix for the number to show and the color to paint right in the Component Class:

import { Component } from '@angular/core';

@Component({
  selector: 'my-app',
  templateUrl: './app.ponent.html',
  styleUrls: ['./app.ponent.css']
})
export class AppComponent {
  rows = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9];
  cols = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9];
  matrix = [];

  model1 = '';
  model2 = '';
  model3 = '';
  model4 = '';
  model5 = '';

  ngOnInit() {
    this.rows.forEach((row, rowIndex) => {
      this.matrix.push([]);
      this.cols.forEach((col, colIndex) => {
        const product = row * col;
        this.matrix[row].push({
          numberToShow: product,
          color: this.getBG(product),
        });
      })
    });
  }

  getBG(hue: number): string {
    console.log('getBG was called');
    return 'hsl(' + hue + ', 100%, 50%)';
  }

}

And then use it in your template:

<br/>
<div> 1. Open a console</div>
<br/>

<section>
    <div class="row" *ngFor="let row of matrix">
        <div 
      class="col" 
      [style.background-color]="col.color" 
      *ngFor="let col of row ">
            {{col.numberToShow}}
        </div>
    </div>
</section>

<br/>
<div>2. Click fast on the different inputs: </div>
<br/>

<section>
    <input type="text" [ngModel]="model1"/>
  <input type="text"[ngModel]="model2"/>
  <input type="text"[ngModel]="model3"/>
  <input type="text"[ngModel]="model4"/>
  <input type="text"[ngModel]="model5"/>
</section>

Difference in the performance:

In the previous implementation, the getBG was called 401 times on initialization.

In the solution implementation, the getBG is called 101 times on initialization.

That's a massive performance gain of around 397%.

Plus there's no extra call to the getBG method when the user focuses and blurs out from any input field.

Here's a Working Sample StackBlitz for your ref.

You might also want to read through a Medium Article that I wrote about Performant Reactive Forms in Angular. Although it's related to Reactive Forms, I've touched upon this aspect, in the article. I'm sure you'll find it helpful.

The detection is slow for 2 reasons. Dev tools are kinda slow and printing many messages can show things even more.

The other point is, that you are doing unnecessary work. By separating the two parts you will be able to change the changeDetection strategy to OnPush.

Simplified example:

@Component({
    selector: 'my-cell',
    template: '<div [ngStyle]="styles"><ng-content></ng-content></div>',
    changeDetection: ChangeDetectionStrategy.OnPush,
})
export class CellComponent {
    @Input() styles: {
    readonly "background-color": string;
  };
}

and

@Component({
    selector: 'my-app',
    templateUrl: './app.ponent.html',
    styleUrls: ['./app.ponent.css']
})
export class AppComponent {
    rows = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9];
    cols = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9];
    matrix: {
        numberToShow: number;
        styles: {
            readonly "background-color": string;
        };
    }[][] = [];

    model1 = '';
    model2 = '';
    model3 = '';
    model4 = '';
    model5 = '';

    ngOnInit() {
        this.rows.forEach((row, rowIndex) => {
            this.matrix.push([]);
            this.cols.forEach((col, colIndex) => {
                const product = row * col;
                const self = this;
                this.matrix[row].push({
                    numberToShow: product,
                    styles: {
                        get "background-color"() {
                            console.log('background-color read');
                            return self.getBG(product)
                        },
                    },
                });
            })
        });
    }

    getBG(hue: number): string {
        return 'hsl(' + hue + ', 100%, 50%)';
    }
}

<section>
    <div class="row" *ngFor="let row of matrix">
        <my-cell [styles]="col.styles" *ngFor="let col of row">
            {{col.numberToShow}}
        </my-cell>
    </div>
</section>

<section>
    <input type="text" [ngModel]="model1"/>
    <input type="text" [ngModel]="model2"/>
    <input type="text" [ngModel]="model3"/>
    <input type="text" [ngModel]="model4"/>
    <input type="text" [ngModel]="model5"/>
</section>

The OnPush detection strategy means that, if any of @Inputs of given Component/Directive changes, it will trigger do detection. If you want to make use of that, you have to separate the expensive part into a separate directive, while making sure, its @Inputs will only change if necessary.

StackBlitz: https://stackblitz./edit/style-performance-of-a-grid-fzbzkz