javascript - Making images appear AND other images disappear with the click of a button

I am having some trouble with my webpage. I researched on this topic for 30 minutes straight and still found no direct answer.

If I click button1:

image1 visible
image2 invisible
image3 invisible

If I click button2:

image1 invisible
image2 visible
image3 invisible

If I click button3:

image1 invisible
image2 invisible
image3 visible

Here is my Javascript:

function rock(){
document.getElementById('image1').style.display = 'block';
}
document.getElementById('image2').style.display = 'none';
}
document.getElementById('image3').style.display = 'none';
}

function paper(){
document.getElementById('image1').style.display = 'none';
}
document.getElementById('image2').style.display = 'block';
}
document.getElementById('image3').style.display = 'none';
}

function scissors(){
document.getElementById('image1').style.display = 'none';
}
document.getElementById('image2').style.display = 'none';
}
document.getElementById('image3').style.display = 'block';
}

Here is my HTML:

<button id="rock" onclick="rock()">Rock</button>
<button id="paper" onclick="paper()">Paper</button>
<button id="scissors" onclick="scissors()">Scissors</button>

I am having some trouble with my webpage. I researched on this topic for 30 minutes straight and still found no direct answer.

If I click button1:

image1 visible
image2 invisible
image3 invisible

If I click button2:

image1 invisible
image2 visible
image3 invisible

If I click button3:

image1 invisible
image2 invisible
image3 visible

Here is my Javascript:

function rock(){
document.getElementById('image1').style.display = 'block';
}
document.getElementById('image2').style.display = 'none';
}
document.getElementById('image3').style.display = 'none';
}

function paper(){
document.getElementById('image1').style.display = 'none';
}
document.getElementById('image2').style.display = 'block';
}
document.getElementById('image3').style.display = 'none';
}

function scissors(){
document.getElementById('image1').style.display = 'none';
}
document.getElementById('image2').style.display = 'none';
}
document.getElementById('image3').style.display = 'block';
}

Here is my HTML:

<button id="rock" onclick="rock()">Rock</button>
<button id="paper" onclick="paper()">Paper</button>
<button id="scissors" onclick="scissors()">Scissors</button>

Share Improve this question edited Apr 7, 2014 at 21:05 asked Apr 7, 2014 at 20:52 Ms. Speled 351 gold badge1 silver badge8 bronze badges

1 If you want us to tell you what's wrong with what you've tried, you have to post the code. We're not going to just write it for you. – Barmar Commented Apr 7, 2014 at 20:55

Add a ment |

2 Answers 2

Sorted by: Reset to default 2

simply use this to hide it:

document.getElementById("thingid").style.visibility="hidden";

use this to show it:

document.getElementById("thingid").style.visibility="visible";

Very nice tutorial on this page: http://www.w3schools./jsref/prop_style_visibility.asp

2ndary suggestion: you can use jquery to create nice transition effects

Give id to all buttons
Give id to all images
Add event handler to each button
Hide an image like this

document.getElementById("id-of-the-image").style.display = "none";
Show an image like this

document.getElementById("id-of-the-image").style.display = "inline-block";

Your code (with correction)

function rock(){
    document.getElementById('image1').style.display = 'block';
    document.getElementById('image2').style.display = 'none';
    document.getElementById('image3').style.display = 'none';
}

function paper(){
    document.getElementById('image1').style.display = 'none';
    document.getElementById('image2').style.display = 'block';
    document.getElementById('image3').style.display = 'none';
}

function scissors(){
    document.getElementById('image1').style.display = 'none';
    document.getElementById('image2').style.display = 'none';
    document.getElementById('image3').style.display = 'block';
}

An optimized version of your code

function showImage(imageId) {
    document.getElementById(imageId).style.display = 'block';
}
function hideImage() {
    document.getElementById(imageId).style.display = 'none';
}


function rock(){
    showImage('image1');
    hideImage('image2');
    hideImage('image3');
}

function paper(){
    hideImage('image1');
    showImage('image2');
    hideImage('image3');
}

function scissors(){
    hideImage('image1');
    hideImage('image2');
    showImage('image3');
}

科技改变生活-雨落星辰 - 所有的伟大,都源于一个勇敢的开始

javascript - Making images appear AND other images disappear with the click of a button - Stack Overflow

2 Answers 2

与本文相关的文章

评论列表(0)