Sample code:
function test_loaded() {
require_once 'file.php';
$ins = Sample_Class::instance();
require_once 'file2.php';
}
add_action('plugins_loaded', 'test_loaded');
in file.php
class Sample_Class {
public static $instance = null;
public static function instance() {
if(null == self::$instance) {
self::$instance = new Sample_Class();
}
return self::$instance;
}
public static function sample($a1) {
$a2 = get_option($a1);
return $a2;
}
}
in file2.php
$a3 = Sample_Class::instance();
function sample2() {
global $a3;
echo $a3->sample('test');
}
add_action('wp_head', 'sample2');
function sample3() {
global $a3;
echo $a3->sample('test2');
}
add_action('wp_footer', 'sample3');
Problem:
Sample2 expected output head section: get_option('test') -> this value But $a3 is output null (i use var_dump($a3) in function) No error appears on sample3 function side and outputs $ a3 is object. (i use var_dump())
Anyone have any ideas? Why am I having trouble using the wp_head hook.
My workaround is: To redefine $a3 inside the sample2 function instead of using global. It works this way. But I don't know why I should use it like that.
Sample code:
function test_loaded() {
require_once 'file.php';
$ins = Sample_Class::instance();
require_once 'file2.php';
}
add_action('plugins_loaded', 'test_loaded');
in file.php
class Sample_Class {
public static $instance = null;
public static function instance() {
if(null == self::$instance) {
self::$instance = new Sample_Class();
}
return self::$instance;
}
public static function sample($a1) {
$a2 = get_option($a1);
return $a2;
}
}
in file2.php
$a3 = Sample_Class::instance();
function sample2() {
global $a3;
echo $a3->sample('test');
}
add_action('wp_head', 'sample2');
function sample3() {
global $a3;
echo $a3->sample('test2');
}
add_action('wp_footer', 'sample3');
Problem:
Sample2 expected output head section: get_option('test') -> this value But $a3 is output null (i use var_dump($a3) in function) No error appears on sample3 function side and outputs $ a3 is object. (i use var_dump())
Anyone have any ideas? Why am I having trouble using the wp_head hook.
My workaround is: To redefine $a3 inside the sample2 function instead of using global. It works this way. But I don't know why I should use it like that.
Share Improve this question asked Sep 21, 2020 at 20:58 Akın OcakAkın Ocak 32 bronze badges 1 |1 Answer
Reset to default 0As an alternative you could try declaring it with $GLOBALS['a3'] in file2 to make sure it becomes a global:
$GLOBALS['a3'] = Sample_Class::instance();
I'd guess the current $a3 declaration in file2's top level scope doesn't count as global because it gets inluded inside the test_loaded() scope. From the 'include' docs (which cover require and require_once too):
When a file is included, the code it contains inherits the variable scope of the line on which the include occurs. Any variables available at that line in the calling file will be available within the called file, from that point forward. However, all functions and classes defined in the included file have the global scope.
So it looks like variables declared at file scope in an included file are an exception to true global scope. However I'm surprised there's not an equivalent exception to allow them to be accessed as globals from file2 anyway, since that changes how $a3 behaves depending on how the file can be included.
If you don't need $a3 to be global outside file2, another option might be to change sample2() into an anonymous closure that includes $a3 with a 'use':
$a3 = Sample_Class::instance();
add_action( 'wp_head', function() use ($a3) {
echo $a3->sample('test');
});
file2you're trying to use global variables named$a3but that variable doesn't exist, nowhere do you declare a global variable then create it. You should not use global variables to build your logic, or singletons with only static functions. The problem here has nothing to do with hooks – Tom J Nowell ♦ Commented Sep 21, 2020 at 22:19