hi i check the blank field in the form and alert the user. but when alert the user it posts the data i couldnt return false not to refresh the page

$('#loginAccount').submit(function() {
    $(this).find(':input:text').each(function(i) {
        if($(this).val()=="") {
            // alert($('label').eq(i).html())
            $('#alert3').html('Please fill all fields.');
            return false;
        }
    });
});

hi i check the blank field in the form and alert the user. but when alert the user it posts the data i couldnt return false not to refresh the page

$('#loginAccount').submit(function() {
    $(this).find(':input:text').each(function(i) {
        if($(this).val()=="") {
            // alert($('label').eq(i).html())
            $('#alert3').html('Please fill all fields.');
            return false;
        }
    });
});

• javascript
• jquery
• forms

4 Answers 4

$('#loginAccount').submit(function() {
    var valid = true;
    $(this).find(':input:text').each(function(i) {
        if($(this).val() == "") {
            // alert($('label').eq(i).html())
            $('#alert3').html('Please fill all fields.');
            valid = false;
        }
    });
    return valid;
});

You are currently returning from the each. What you need to do is track whether it's valid and then use that value as the return from your submit.

return false; takes on a different meaning inside of a jQuery each(). It is used to break out of the each. Maybe you could set a flag that is observed after the each() to see if the validation succeeded.

You need to return false in the submit function, not the each function:

$('#loginAccount').submit(function() {
    var isValid = true;
    $(this).find(':input:text').each(function(i) {
        if($(this).val()=="")
        {
            isValid = false;
            //alert($('label').eq(i).html())
            $('#alert3').html('Please fill all fields.');

        }
    });
    return isValid;
});

May be you shoul use closure to return a value?

    $('#loginAccount').submit(function() {
           var result = true;    
            $(this).find(':input:text')
                 .each(function(i) {
                if($(this).val()=="")
                {
                    //alert($('label').eq(i).html())
                    $('#alert3').html('Please fill all fields.');
                    result = false;
                }
            });
            return result;
            })