I'm writing an app that uses Rails on the backend and javascript/backbone on the frontend. I'm trying to bootstrap some rails models into my javascript. Specifically, I'd like to load the contents of @courses
into a js variable called window.courses
. I've got the following in an html.erb
file.
<%= javascript_tag do %>
window.courses = JSON.parse('<%= @courses.to_json %>');
<% end %>
I'm expecting the erb
preprocessor to render this into valid javascript, like so
<script type="text/javascript">
//<![CDATA[
window.courses = JSON.parse('[{"code":"myCourseCode", ...
//]]>
</script>
... but, instead, I'm getting code that includes HTML entities.
<script type="text/javascript">
//<![CDATA[
window.courses = JSON.parse('[{"code":"myCourseCode", ...
//]]>
</script>
Obviously, I get javascript errors when I try to parse this.
Does anyone know how I can deal with these HTML entities in order to produce valid javascript? I realize that one option would be to unescape the entities on the client side, but this seems like a roundabout solution. Is there a way that I can get Rails to produce JSON that doesn't need unescaping?
I'm writing an app that uses Rails on the backend and javascript/backbone on the frontend. I'm trying to bootstrap some rails models into my javascript. Specifically, I'd like to load the contents of @courses
into a js variable called window.courses
. I've got the following in an html.erb
file.
<%= javascript_tag do %>
window.courses = JSON.parse('<%= @courses.to_json %>');
<% end %>
I'm expecting the erb
preprocessor to render this into valid javascript, like so
<script type="text/javascript">
//<![CDATA[
window.courses = JSON.parse('[{"code":"myCourseCode", ...
//]]>
</script>
... but, instead, I'm getting code that includes HTML entities.
<script type="text/javascript">
//<![CDATA[
window.courses = JSON.parse('[{"code":"myCourseCode", ...
//]]>
</script>
Obviously, I get javascript errors when I try to parse this.
Does anyone know how I can deal with these HTML entities in order to produce valid javascript? I realize that one option would be to unescape the entities on the client side, but this seems like a roundabout solution. Is there a way that I can get Rails to produce JSON that doesn't need unescaping?
Share Improve this question edited May 23, 2017 at 12:34 CommunityBot 11 silver badge asked Oct 8, 2012 at 19:20 dB'dB' 8,33016 gold badges61 silver badges108 bronze badges 3-
2
Try using
<%= raw(@courses.to_json) %>
– Raul Pinto Commented Oct 8, 2012 at 19:46 - Brilliant, thanks! I figured there must be a simple way to do this. – dB' Commented Oct 8, 2012 at 19:49
- @dB' would you consider updating the accepted answer? this is very unsafe and has been the source of many cross-site scripting vulnerabilities. – oreoshake Commented Jul 15, 2015 at 7:05
2 Answers
Reset to default 9If you intend to use raw(obj.to_json) you MUST ensure the following is set.
ActiveSupport.escape_html_entities_in_json = true
The question is solved by my ment, just for the record:
Rails escapes strings that are printed using <%= 'string' %>
. By this, it is save to ouput user data.
So, if you don't want Rails to escape the output, you have to tell Rails explicitly by using raw('string')
.
In your code, that would be:
<%= raw(@courses.to_json) %>