I'm working on some plicated form at the moment.

Just wondering, is there any better way to do this:

$('.selector').each( function(){

    $("input", this).prop('disabled', true);
    $("select", this).prop('disabled', true);
    $("label", this).prop('disabled', true);
    $("textarea", this).prop('disabled', true);

});

I want to select all inputs within this (currently looped through .selector). Am I doing this correctly?

I'm working on some plicated form at the moment.

Just wondering, is there any better way to do this:

$('.selector').each( function(){

    $("input", this).prop('disabled', true);
    $("select", this).prop('disabled', true);
    $("label", this).prop('disabled', true);
    $("textarea", this).prop('disabled', true);

});

I want to select all inputs within this (currently looped through .selector). Am I doing this correctly?

• javascript
• jquery
• html
• jquery-selectors

• 1 Yes, technically. Although @BoltClock's answer below is a better way of doing this. – rossipedia Commented Nov 14, 2011 at 15:34

1 Answer 1

That's fine, but to simplify it you should be able to use the ma as you would to group any other selectors:

$('.selector').each(function() {
    $('input, select, label, textarea', this).prop('disabled', true);
});

If the only thing you're doing is setting that property on those elements, then you don't really need the .each() loop. You can safely drop that and reduce it to this one-liner:

$('input, select, label, textarea', '.selector').prop('disabled', true);