<select data-myattr="123" id="cboTest" 
        onchange="SayHello(this.data-myattr)">

This doesn't work. If I take the data-off of it it, it works, but from what I've read, it is html5 safe to do it that way. However, doing it that way, I get: "Microsoft JScript runtime error: 'myattr' is undefined".

This is my super-complex function:

function SayHello(msg) {
    alert(msg);
}

Thanks in advance.

<select data-myattr="123" id="cboTest" 
        onchange="SayHello(this.data-myattr)">

This doesn't work. If I take the data-off of it it, it works, but from what I've read, it is html5 safe to do it that way. However, doing it that way, I get: "Microsoft JScript runtime error: 'myattr' is undefined".

This is my super-complex function:

function SayHello(msg) {
    alert(msg);
}

Thanks in advance.

• javascript
• html
• onchange

• 4 this.dataset.myattr (won't work in "shitty" browsers) – Šime Vidas Commented Jul 24, 2012 at 17:13
• 1 You probably meant legacy browsers. – Frédéric Hamidi Commented Jul 24, 2012 at 17:15
• 2 @FrédéricHamidi Yea, that would be the appropriate term :) – Šime Vidas Commented Jul 24, 2012 at 17:17
• They don't call them "shitty" in the biz? Hehe. – Yatrix Commented Jul 24, 2012 at 17:17
• 1 @Yatrix, sometimes we have to support them. Calling them names only lowers morale and doesn't achieve much, calling them legacy conveys more of a sense of positive, backwards compatibility effort instead. – Frédéric Hamidi Commented Jul 24, 2012 at 17:20

3 Answers 3

Try like this:

<select data-myattr="123" id="cboTest" 
        onchange="SayHello(this.getAttribute('data-myattr'))">

The expression:

onchange="SayHello(this.data-myattr)">

Is being interpretted as this.data minus myattr. You'd have to use:

onchange="SayHello(this.getAttribute('data-myattr'))"

instead.

Something like getAttribute() should do

Here's an example:

<select data-myattr="123" id="cboTest" 
onchange="SayHello(this.getAttribute('data-myattr'))">
    <option>1</option>
    <option>2</option>
</select>

Also, I'd try avoiding the use of inline scripts since they make HTML messy. Use addEventListener/attachEvent (older IE) instead.