The following works:
$ = document.form;
x = $.name.value;
This doesn't:
$ = document.getElementById;
x = $("id").value;
Any ideas on why this doesn't work or how to make it so?
The following works:
$ = document.form;
x = $.name.value;
This doesn't:
$ = document.getElementById;
x = $("id").value;
Any ideas on why this doesn't work or how to make it so?
Share Improve this question asked Mar 21, 2012 at 12:42 Bret ThomasBret Thomas 3372 gold badges5 silver badges16 bronze badges 2- You might find your answer between the lines in this post/answer: stackoverflow.com/a/9612657/77047 – Chris Tonkinson Commented Mar 21, 2012 at 12:48
- I'm not sure it's an exact duplicate per se, but this covers the same ground as stackoverflow.com/questions/6398787/… – lonesomeday Commented Mar 21, 2012 at 12:50
5 Answers
Reset to default 11The value of this
depends on how you call the function.
When you call document.getElementById
then getElementById
gets this === document
. When you copy getElementById
to a different variable and then call it as $
then this === window
(because window
is the default variable).
This then causes it to look for the id in the window object instead of in the document object, and that fails horribly because windows aren't documents and don't have the same methods.
You need to maintain the document
in the call. You can use a wrapper functions for this e.g.
function $ (id) { return document.getElementById(id); }
… but please don't use $
. It is a horrible name. It has no meaning and it will confuse people who see it and think "Ah! I know jQuery!" or "Ah! I know Prototype" or etc etc.
The context object is different. When you get a reference of a function you're changing that context object:
var john = {
name : "john",
hello : function () { return "hello, I'm " + this.name }
}
var peter = { name : "peter" };
peter.hello = john.hello;
peter.hello() // "hello, I'm peter"
If you want a reference function bound to a specific context object, you have to use bind:
peter.hello = john.hello.bind(john);
peter.hello(); // "hello, I'm john"
So in your case it will be:
var $ = document.getElementById.bind(document);
Don't know what you want to achieve, but this can be made working like this
$ = document.getElementById;
x = $.call(document, "id").value;
because getElementById
works only when it is a function of document
because of the scope it needs.
But I would recommend @Quentin's answer.
getElementById
is a method of the HTMLDocument
prototype (of which document
is an instance). So, calling the function in global context you will surely get an "Wrong this Error" or something.
You may use
var $ = document.getElementById.bind(document);
but
function $(id) { return document.getElementById(id); }
is also OK and maybe better to understand.
If you are trying to achieve something like that I would suggest using jQuery. Their $ notation is much more powerful than just getting an element by id.
Also, if you are using any platform that already uses the $ as a variable (ASP .Net sometimes uses this) you may have unpredictable result.