I have some code implementing a context menu on a textbox, the context menu is to have an Undo
and Redo
item that calls the browsers native methods by using document.execCommand('undo')
.
This code functions as I require on Chromium based browsers but on FireFox and Opera the results are not as expected.
My expectation is that undo and redo will function like the native browser context menu for an input element. The result is that the input elements do not undo and redo, however div elements with the contenteditable
attribute set, do function as expected.
So I'm wondering if this is a bug in one of the browsers, either Chromium or FireFox/Opera, or if I am not implementing the code correctly?
The following code gives an example of the issue that I'm facing. All help is appreciated.
<input contenteditable id="input" type="text"></input>
<div contenteditable id="div" class="inputLike" type="text"></div>
<button id="button1" type="button">Undo</button>
<button id="button2" type="button">Redo</button>
var input = document.getElementById("input"),
button1 = document.getElementById("button1"),
button2 = document.getElementById("button2"),
div = document.getElementById("div");
console.log("Undo", document.queryCommandSupported("undo"));
console.log("Redo", document.queryCommandSupported("redo"));
function doUndo() {
document.execCommand('undo', false, null);
}
function doRedo() {
document.execCommand('redo', false, null);
}
button1.addEventListener("click", doUndo, false);
button2.addEventListener("click", doRedo, false);
On jsfiddle
If you want to look at the actual context menu code, then it is also available on jsfiddle.
I have some code implementing a context menu on a textbox, the context menu is to have an Undo
and Redo
item that calls the browsers native methods by using document.execCommand('undo')
.
This code functions as I require on Chromium based browsers but on FireFox and Opera the results are not as expected.
My expectation is that undo and redo will function like the native browser context menu for an input element. The result is that the input elements do not undo and redo, however div elements with the contenteditable
attribute set, do function as expected.
So I'm wondering if this is a bug in one of the browsers, either Chromium or FireFox/Opera, or if I am not implementing the code correctly?
The following code gives an example of the issue that I'm facing. All help is appreciated.
<input contenteditable id="input" type="text"></input>
<div contenteditable id="div" class="inputLike" type="text"></div>
<button id="button1" type="button">Undo</button>
<button id="button2" type="button">Redo</button>
var input = document.getElementById("input"),
button1 = document.getElementById("button1"),
button2 = document.getElementById("button2"),
div = document.getElementById("div");
console.log("Undo", document.queryCommandSupported("undo"));
console.log("Redo", document.queryCommandSupported("redo"));
function doUndo() {
document.execCommand('undo', false, null);
}
function doRedo() {
document.execCommand('redo', false, null);
}
button1.addEventListener("click", doUndo, false);
button2.addEventListener("click", doRedo, false);
On jsfiddle
If you want to look at the actual context menu code, then it is also available on jsfiddle.
Share Improve this question edited Apr 25, 2013 at 23:38 Xotic750 asked Apr 25, 2013 at 22:21 Xotic750Xotic750 23.5k8 gold badges59 silver badges81 bronze badges 4-
I think that
execCommand()
is only supported for "contenteditable" sections in Firefox, and not for<input>
elements. – Pointy Commented Apr 25, 2013 at 22:27 - I've tried to search for some hard documentation about this but haven't been able to find anything concrete. If you know of any or any other possible methods? – Xotic750 Commented Apr 25, 2013 at 22:37
-
Well all I know is that
execCommand()
only shows up on MDN in the documentation for "rich editing". – Pointy Commented Apr 25, 2013 at 22:40 -
Hello! I don't think it's possible with
document.execCommand()
, in Firefox at least. – Tim Down Commented Apr 26, 2013 at 9:05
3 Answers
Reset to default 2I don't think it's possible with document.execCommand()
, in Firefox at least. You could make your own undo stack, or in future use the new UndoManager API (implemented in Firefox 20 but disabled by default).
Here's an example of using your own undo stack by taking snapshots of the value and selection using the input
event. You could improve this by merging consecutive typing events into a single undo item, for example. There is also some inconsistency between browsers with the caret position, but it's just a proof of concept.
http://jsfiddle/FMSsL/
Using the new DOM UndoManager API seems to be simple: if I understand it right and if the browser supports it, the <input>
element will have an undoManager
property, which is an object with undo()
and redo()
methods, so the task is as simple as
document.getElementById("input").undoManager.undo();
Unfortunately only Firefox 20 and above supports the UndoManager
API and it's disabled by default. Even once it's enabled, the following demo does not work even though I think it should, so this option is some way off being viable.
http://jsfiddle/DULV4/2/
As I discovered from the question I asked, the undoManager API in Firefox DOES work. I looked at the jsFiddle link (http://jsfiddle/DULV4/1/) posted by Tim Down, and there appear to be a couple issues:
- An
undoScope
attribute must be set totrue
(either in-line or programmatically). This enables theundoManager
for that element. - Anything you undo has to first be created by the
undoManager.transact()
function (though I'm wondering if there is any way to incorporate the native undo stack into the current undoManager's transaction history).
I'm only a novice with this, so take what I say with a grain of salt and see https://dvcs.w3/hg/undomanager/raw-file/tip/undomanager.html for all the information on using it.
IT IS POSSIBLE TO GET HISTORY OF THE UNDO AND REDO
function check(){
if(document.queryCommandEnabled("undo"))
{
$('#undoResult').text("Undo is active");
}else{
$('#undoResult').text("Undo is not active");
}
if(document.queryCommandEnabled("redo"))
{
$('#redoResult').text("Redo is active");
}else{
$('#redoResult').text("Redo is not active");
}
}
$(document).on('keypress',function(e) {
if(e.which == 13) {
document.execCommand("insertLineBreak");
return false;
}
});
check();
div{
border:1px solid black;
height:100px;
}
button{
color:white;
background:black;
height:40px;
width:49%;
padding:1px;
text-align:center;
margin-top:10px;
}
p{
font-size:30px;
}
<script src="https://cdnjs.cloudflare./ajax/libs/jquery/3.3.1/jquery.min.js"></script>
<div contenteditable="true">
</div>
<button onclick="document.execCommand('undo',false,null);check()" >Undo</button>
<button onclick="document.execCommand('redo',false,null); check()" >Redo</button>
<p id='undoResult'></p>
<p id='redoResult'></p>